validation added to NumericalInput to just accept numerical values on block creation form by jesusbalderramawgu · Pull Request #2615 · openedx/frontend-app-authoring

jesusbalderramawgu · 2025-11-11T17:42:43Z

Description

There's a bug with Numerical Input Component which Incorrectly Handles Formulas as numericalresponse.
after some research and talking with the community we agreed to validate the author block form to just accept numeric values in the answers.

this is how the form will show the error if the value is not numeric.

it closes [#1680]

Testing instructions

First you need to use edx-platform with this branch OEXCOM-245/numericalinput-validation

Create or select in Studio
Create a section inside the course
Create a subsection inside the secion
Click on "New unit" button inside the subsection

Then you will be redirected to this view

Select the "Problem" button, then a modal will pop up and finally select the "Numerical input" option.

scroll down in the modal and you will see a block called "Answers"

In that input is where you can add the numerical input and see the response from the API.

Valid formula

Invalid formula

openedx-webhooks · 2025-11-11T17:42:48Z

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

diana-villalvazo-wgu · 2025-11-11T18:21:36Z

Suggestion: In the description of the PR you can add Fixes #{PR number} or Closes #{PR number} so when this PR is merged the Github issue will be closed automatically

jacobo-dominguez-wgu · 2025-11-12T19:15:27Z

You need to follow the conventional commits messages

bradenmacdonald · 2025-11-13T17:22:18Z

Thanks! Let me know once the other reviewers have approved it, or if you need me to approve some more test runs.

kdmccormick

Thanks for your work so far @jesusbalderramawgu !

codecov · 2025-11-14T22:53:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.92%. Comparing base (36c9eba) to head (696bb7f).
⚠️ Report is 78 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2615      +/-   ##
==========================================
+ Coverage   94.81%   94.92%   +0.11%     
==========================================
  Files        1225     1239      +14     
  Lines       27481    28448     +967     
  Branches     6187     6296     +109     
==========================================
+ Hits        26056    27005     +949     
- Misses       1367     1385      +18     
  Partials       58       58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…alues

Co-authored-by: Kyle McCormick <kyle@kylemccormick.me>

jesusbalderramawgu · 2025-11-15T00:20:27Z

You need to follow the conventional commits messages

thanks, I made the change in the current commit messages and I'll keep this in mind for future PR

… to see if is a valid math expression

…f redux

…der added

bradenmacdonald · 2025-12-10T23:18:36Z

I believe this is blocked on openedx/openedx-platform#37677

kdmccormick · 2025-12-16T22:24:51Z

@bradenmacdonald The linked edx-platform PR is unblocked now, would you like to review this or should I?

bradenmacdonald · 2025-12-18T01:05:00Z

@kdmccormick I can review.

bradenmacdonald · 2025-12-18T17:25:18Z

          )}
-          {isPending && (
-            <Spinner animation="border" className="mie-3 mt-3" screenReaderText="loading" />
-          )}


Why did you remove the spinner?

because I realized it wasn't necessary, none of the forms have it. Also it was causing a bouncing in the modal on typing.

bradenmacdonald · 2025-12-18T17:25:37Z

Please get the coverage test passing again and then I can approve and merge.

braden's review is sufficient

jesusbalderramawgu · 2025-12-18T22:18:36Z

Please get the coverage test passing again and then I can approve and merge.
I fixed the coverage test, Thank you @bradenmacdonald!

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 11, 2025

openedx-webhooks added this to Contributions Nov 11, 2025

github-project-automation Bot moved this to Needs Triage in Contributions Nov 11, 2025

holaontiveros approved these changes Nov 11, 2025

View reviewed changes

diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 11, 2025

diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Nov 11, 2025

diana-villalvazo-wgu reviewed Nov 11, 2025

View reviewed changes

Comment thread src/editors/containers/ProblemEditor/components/EditProblemView/AnswerWidget/messages.js Outdated

diana-villalvazo-wgu requested a review from bradenmacdonald November 11, 2025 18:28

jacobo-dominguez-wgu reviewed Nov 11, 2025

View reviewed changes

Comment thread src/editors/containers/ProblemEditor/components/EditProblemView/AnswerWidget/messages.js Outdated

kdmccormick previously requested changes Nov 13, 2025

View reviewed changes

mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Nov 13, 2025

kdmccormick mentioned this pull request Nov 14, 2025

[DEPR]: Legacy Problem Editor openedx/openedx-platform#36261

Closed

jesusbalderramawgu and others added 3 commits November 14, 2025 18:11

feat(form): add validation to NumericalInput to accept only numeric v…

740a7b8

…alues

style(format): fix spaces and update message to camelCase

d669d7e

fix(content): update text for clarity

14d2c72

Co-authored-by: Kyle McCormick <kyle@kylemccormick.me>

jesusbalderramawgu force-pushed the OEXCOM-245/AUTH-BLOCK-FORM-VALIDATION branch from 842e6a2 to 14d2c72 Compare November 15, 2025 00:15

feat(validation): validation added to numeric input with new endpoint…

c24cb0d

… to see if is a valid math expression

jesusbalderramawgu mentioned this pull request Nov 24, 2025

feat(numericalInput): endpoint added to validate a numerical input openedx/openedx-platform#37677

Merged

diana-villalvazo-wgu reviewed Nov 24, 2025

View reviewed changes

Comment thread src/editors/data/redux/thunkActions/requests.js Outdated

kdmccormick self-requested a review November 24, 2025 20:12

jesusbalderramawgu added 4 commits November 24, 2025 18:18

fix(content): change in input validation to use react query instead o…

49ac070

…f redux

fix(content): change in types to avoid ci errors

0b72cd9

fix(content): remove unnecessary code after changing to react query

9b57066

fix(content): change numeric input validation path to new url and loa…

f9ce381

…der added

bradenmacdonald moved this from In Eng Review to Blocked in Contributions Dec 10, 2025

mphilbrick211 moved this from Blocked to In Eng Review in Contributions Dec 12, 2025

bradenmacdonald reviewed Dec 18, 2025

View reviewed changes

Comment thread src/editors/containers/ProblemEditor/data/apiHooks.ts

Comment thread src/editors/containers/ProblemEditor/data/apiHooks.ts Outdated

feat: returning data in camelcase, improve UI in validation

7ad1f7e

bradenmacdonald reviewed Dec 18, 2025

View reviewed changes

kdmccormick removed their request for review December 18, 2025 21:23

feat: tests added to problem editor

696bb7f

bradenmacdonald approved these changes Dec 19, 2025

View reviewed changes

bradenmacdonald merged commit 9072bb6 into openedx:master Dec 19, 2025
7 checks passed

github-project-automation Bot moved this from In Eng Review to Done in Contributions Dec 19, 2025

kdmccormick mentioned this pull request Jan 15, 2026

Numerical Input Component Incorrectly Handles Formulas as numericalresponse #1680

Closed

bradenmacdonald mentioned this pull request Jan 29, 2026

chore: clean up ValidationResult for NumericalInput problems #2849

Merged

7 tasks

Conversation

jesusbalderramawgu commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

openedx-webhooks commented Nov 11, 2025

Uh oh!

diana-villalvazo-wgu commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

jacobo-dominguez-wgu commented Nov 12, 2025

Uh oh!

bradenmacdonald commented Nov 13, 2025

Uh oh!

kdmccormick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jesusbalderramawgu commented Nov 15, 2025

Uh oh!

Uh oh!

bradenmacdonald commented Dec 10, 2025

Uh oh!

kdmccormick commented Dec 16, 2025

Uh oh!

bradenmacdonald commented Dec 18, 2025

Uh oh!

Uh oh!

Uh oh!

bradenmacdonald Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

jesusbalderramawgu Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald commented Dec 18, 2025

Uh oh!

jesusbalderramawgu commented Dec 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jesusbalderramawgu commented Nov 11, 2025 •

edited

Loading

codecov Bot commented Nov 14, 2025 •

edited

Loading